Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Align 'configStorage' object to theia changes #640

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Align 'configStorage' object to theia changes #640

merged 1 commit into from
Feb 27, 2020

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Feb 26, 2020 •
edited
Loading

What does this PR do?

Align 'configStorage' object to theia changes

What issues does this PR fix or reference?

eclipse-che/che#16149

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

@RomanNikitenko
Align 'configStorage' object to theia changes
96188cb 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko
Copy link
Member Author

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Feb 26, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Feb 26, 2020
@RomanNikitenko RomanNikitenko marked this pull request as ready for review February 26, 2020 20:58
azatsarynnyy
azatsarynnyy approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just started investigating this )
Thanks!

@vzhukovs
Copy link
Contributor

crw-ci-test

@benoitf
Copy link
Contributor

benoitf commented Feb 27, 2020

@RomanNikitenko fixed issue is eclipse-che/che#16149 correct ?

@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Feb 27, 2020 •
edited
Loading

@benoitf
Added to the PR description, thank you!

@eclipse-che eclipse-che deleted a comment from che-bot Feb 27, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Feb 27, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Feb 27, 2020
@dmytro-ndp
Copy link
Contributor

crw-ci-test

@benoitf
Copy link
Contributor

benoitf commented Feb 27, 2020

as build check is passing, I would merge it ?

@eclipse-che eclipse-che deleted a comment from che-bot Feb 27, 2020
@eclipse-che eclipse-che deleted a comment from azatsarynnyy Feb 27, 2020
@eclipse-che eclipse-che deleted a comment from che-bot Feb 27, 2020
@dmytro-ndp
Copy link
Contributor

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Feb 27, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 27, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:640
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:640

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@RomanNikitenko RomanNikitenko merged commit f9a7ef1 into master Feb 27, 2020
@RomanNikitenko RomanNikitenko deleted the fixBuild branch February 27, 2020 10:57
vinokurig added a commit that referenced this pull request Apr 6, 2021
@vinokurig
Update the vscode GitHub Pull Request plugin (#640)
08882d0 
* Update the vscode GitHub Pull Request plugin

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

* fixup! golang sidecar gopls fix (#638)

* fixup! Update the vscode GitHub Pull Request plugin
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vzhukovs vzhukovs vzhukovs approved these changes

@azatsarynnyy azatsarynnyy azatsarynnyy approved these changes

@benoitf benoitf benoitf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RomanNikitenko @vzhukovs @benoitf @dmytro-ndp @che-bot @azatsarynnyy